Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): upgrade socket.io #29765

Merged
merged 2 commits into from
Feb 25, 2021
Merged

chore(gatsby): upgrade socket.io #29765

merged 2 commits into from
Feb 25, 2021

Conversation

wardpeet
Copy link
Contributor

Description

Upgrading socket.io to latest version - subset of #29699

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 25, 2021
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESM import syntax has changed in v3: https://socket.io/docs/v3/server-initialization/index.html

packages/gatsby/src/utils/websocket-manager.ts Outdated Show resolved Hide resolved
packages/gatsby/src/utils/websocket-manager.ts Outdated Show resolved Hide resolved
@ascorbic ascorbic added type: chore and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 25, 2021
@wardpeet wardpeet merged commit 3ab492c into master Feb 25, 2021
@wardpeet wardpeet deleted the v3/socket-io branch February 25, 2021 12:53
ascorbic pushed a commit that referenced this pull request Feb 25, 2021
* chore(gatsby): upgrade socket.io

* fix types

(cherry picked from commit 3ab492c)
ascorbic pushed a commit that referenced this pull request Feb 25, 2021
* chore(gatsby): upgrade socket.io

* fix types

(cherry picked from commit 3ab492c)

Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants