Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-netlify): Add an allow list for redirect options #30155

Merged
merged 3 commits into from
Mar 11, 2021
Merged

fix(gatsby-plugin-netlify): Add an allow list for redirect options #30155

merged 3 commits into from
Mar 11, 2021

Conversation

sidharthachatterjee
Copy link
Contributor

Fixes #29779

Currently we add all values to the redirects file for Netlify. This PR changes that behaviour to only do so for values that are known and documented in https://docs.netlify.com/routing/redirects/

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 10, 2021
@sidharthachatterjee sidharthachatterjee force-pushed the sid/ch26635/fix-issue-in-createredirect-that-broke-gatsby branch from abcd857 to a4d684a Compare March 10, 2021 11:32
@sidharthachatterjee sidharthachatterjee mentioned this pull request Mar 10, 2021
Closed
@LekoArts LekoArts added topic: netlify and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 10, 2021
@LekoArts LekoArts mentioned this pull request Mar 10, 2021
Closed
jaska120
jaska120 suggested changes Mar 10, 2021
View reviewed changes
Copy link

@jaska120 jaska120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Country and Language props should be allowed too

packages/gatsby-plugin-netlify/src/create-redirects.js Show resolved Hide resolved
jaska120
jaska120 approved these changes Mar 10, 2021
View reviewed changes
Copy link

@jaska120 jaska120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wardpeet
wardpeet approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing tests but let's get this in :)

@wardpeet wardpeet merged commit 962c4a1 into master Mar 11, 2021
@wardpeet wardpeet deleted the sid/ch26635/fix-issue-in-createredirect-that-broke-gatsby branch March 11, 2021 09:57
@gatsbybot gatsbybot mentioned this pull request Mar 12, 2021
Merged
pieh pushed a commit that referenced this pull request Mar 12, 2021
@sidharthachatterjee @pieh
fix(gatsby-plugin-netlify): Add an allow list for redirect options (#…
a0d1ac3 
…30155)

(cherry picked from commit 962c4a1)
This was referenced Mar 13, 2021
Merged
Closed
@gatsbybot gatsbybot mentioned this pull request Mar 15, 2021
Merged
vladar pushed a commit that referenced this pull request Mar 15, 2021
@sidharthachatterjee @vladar
fix(gatsby-plugin-netlify): Add an allow list for redirect options (#…
d41f2e2 
…30155)

(cherry picked from commit 962c4a1)
vladar pushed a commit that referenced this pull request Mar 15, 2021
@sidharthachatterjee
fix(gatsby-plugin-netlify): Add an allow list for redirect options (#…
a258996 
…30155) (#30261)

(cherry picked from commit 962c4a1)

Co-authored-by: Sidhartha Chatterjee <me@sidharthachatterjee.com>
@vladar
Copy link
Contributor

vladar commented Mar 15, 2021

Published in gatsby-plugin-netlify@3.0.1

This was referenced Mar 16, 2021
Merged
Closed
This was referenced Mar 17, 2021
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Merged
Merged
This was referenced Mar 17, 2021
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
pieh pushed a commit that referenced this pull request Mar 18, 2021
@sidharthachatterjee
fix(gatsby-plugin-netlify): Add an allow list for redirect options (#…
ebbb41b 
…30155) (#30215)

(cherry picked from commit 962c4a1)

Co-authored-by: Sidhartha Chatterjee <me@sidharthachatterjee.com>
This was referenced Jul 16, 2021
Open
Open
Open
Open
Open
Open
Open
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
fix(gatsby-plugin-netlify): Add an allow list for redirect options (g…
c1f693e 
…atsbyjs#30155)
@tonyg101 tonyg101 mentioned this pull request Jul 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts left review comments

@jaska120 jaska120 jaska120 approved these changes

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createRedirect broke gatsby-plugin-netlify redirects on 2.32.7
5 participants
@sidharthachatterjee @vladar @wardpeet @LekoArts @jaska120