Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): update nested input types when rebuilding SitePage #30426

Merged
merged 1 commit into from
Mar 23, 2021
Merged

fix(gatsby): update nested input types when rebuilding SitePage #30426

merged 1 commit into from
Mar 23, 2021

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Mar 23, 2021

Description

We properly clean up types when rebuilding with site page. But with new graphql-compose we must also explicitly cleanup input types. This PR adds missing pieces for it.

Related Issues

Fixes #30203

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 23, 2021
@vladar vladar added topic: GraphQL Related to Gatsby's GraphQL layer and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 23, 2021
@vladar vladar mentioned this pull request Mar 23, 2021
Closed
@pieh pieh self-assigned this Mar 23, 2021
pieh
pieh approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@vladar vladar merged commit 54d4721 into master Mar 23, 2021
@vladar vladar deleted the vladar/fix-30203 branch March 23, 2021 18:42
@gatsbybot gatsbybot mentioned this pull request Mar 23, 2021
Merged
wardpeet pushed a commit that referenced this pull request Mar 23, 2021
@vladar @wardpeet
fix(gatsby): update nested input types when rebuilding SitePage (#30426)
98b0e92 
(cherry picked from commit 54d4721)
wardpeet pushed a commit that referenced this pull request Mar 29, 2021
@vladar
fix(gatsby): update nested input types when rebuilding SitePage (#30426…
a742927 
…) (#30432)

(cherry picked from commit 54d4721)

Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees

@pieh pieh

Labels
topic: GraphQL Related to Gatsby's GraphQL layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-source-wordpress] Previews break after making a menu item change following a content preview
2 participants
@vladar @pieh