Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update eslint, rollup, webpack and their dependents #30635

Closed

Conversation

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 2, 2021
@hoobdeebla hoobdeebla force-pushed the updates/eslint-rollup-webpack branch from 26f7d98 to d9c9b50 Compare April 2, 2021 07:39
@wardpeet
Copy link
Contributor

wardpeet commented Apr 2, 2021

Thank you but we should be using renovate bot again to do these changes. For example webpack-virtual-modules broke subtle things in watch mode so that's a reason why we're still on the old one.

@wardpeet wardpeet closed this Apr 2, 2021
@hoobdeebla
Copy link
Contributor Author

I understand where you're coming from @wardpeet, but at the same time, I opened this PR because Renovate wasn't updating its own PRs and because there are open Renovate PRs that have been ignored for months. There are packages that break Renovate updates not accounted for in the Renovate config, like webpack-virtual-modules (fixed in #30676).

Interestingly, there are also some Renovate PRs that have been stuck for no discernible reason and have to be manually re-ran. Some are not updating at all; some are still being force-pushed to approximately once a week, but their update list comments are not changing. Here are just a few of the PRs that are stuck:

#27092: readme unchanged since 2020-12-10
#27109: readme unchanged since 2020-11-18 and marked merge-on-green
#27134: readme unchanged since 2020-12-15
#27536: readme unchanged since 2021-01-20
#27898: readme unchanged since 2021-01-31 and marked merge-on-green
#28220: readme unchanged since 2021-02-27
#28508: readme unchanged since 2021-03-22

#28720: artifact update problem on 2021-03-11
#28722: artifact update problem on 2021-03-11
#28775: artifact update problem on 2021-03-11
#29281: artifact update problem on 2021-03-11

#28716: dirty yarn.lock on 2021-03-22
#29383: dirty yarn.lock on 2021-03-22
#29515: dirty yarn.lock on 2021-03-22

@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants