Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add base babelrc support tests for dev and prod #30644

Merged
merged 5 commits into from
Apr 6, 2021
Merged

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Apr 2, 2021

Description

This is adding e2e test cases for .babelrc support. Goal of it is to make sure that #28738 (and any changes to our babel handling in future) doesn't introduce regressions

Done

  • Add cases for develop HMR:
    • editing .babelrc
    • adding new .babelrc
    • deleting .babelrc

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 2, 2021
@pieh pieh added topic: webpack/babel Webpack or babel and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 2, 2021
@pieh pieh force-pushed the e2e/babelrc branch 2 times, most recently from b14ba07 to a5ef0b5 Compare April 2, 2021 22:01
@pieh pieh marked this pull request as ready for review April 2, 2021 23:29
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement to our pipeline. Thanks!

@vladar vladar merged commit 8950c4f into master Apr 6, 2021
@vladar vladar deleted the e2e/babelrc branch April 6, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: webpack/babel Webpack or babel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants