Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-wordpress): only log out duplicate nodes if we have all the data we want to log (#30751) #30759

Merged
merged 1 commit into from
Apr 9, 2021
+23 −12
Merged

fix(gatsby-source-wordpress): only log out duplicate nodes if we have all the data we want to log (#30751) #30759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 23 additions & 12 deletions packages/gatsby-source-wordpress/src/steps/source-nodes/fetch-nodes/fetch-nodes-paginated.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,24 +95,35 @@ const paginatedWpNodeFetch = async ({
nodes.forEach(node => {
const existingId = idSet.has(node.id)

if (existingId) {
if (
existingId &&
// when the since variable is present
// we're fetching lists of node updates from WPGQL
// in that case we don't need to worry about logging duplicates
!(`since` in variables)
) {
const existingNode = allContentNodes.find(
innerNode => innerNode.id === node.id
)

if (!hasLoggedDuplicateMessage) {
hasLoggedDuplicateMessage = true
helpers.reporter.warn(
formatLogMessage(
`Found a duplicate ID in WordPress - this means you will have fewer nodes in Gatsby than in WordPress. This will need to be resolved in WP by identifying and fixing the underlying bug with your WP plugins or custom code.`
if (existingNode) {
if (!hasLoggedDuplicateMessage) {
hasLoggedDuplicateMessage = true
helpers.reporter.warn(
formatLogMessage(
`Found a duplicate ID in WordPress - this means you will have fewer nodes in Gatsby than in WordPress. This will need to be resolved in WP by identifying and fixing the underlying bug with your WP plugins or custom code.`
)
)
)
}

if (node?.databaseId && node?.uri && existingNode?.uri) {
helpers.reporter.info(
formatLogMessage(
`#${node.databaseId} (${node.uri}) is a duplicate of ${existingNode.databaseId} (${existingNode.uri})`
)
)
}
}
helpers.reporter.info(
formatLogMessage(
`#${node.databaseId} (${node?.uri}) is a duplicate of ${existingNode.databaseId} (${existingNode?.uri})`
)
)
} else {
idSet.add(node.id)
}
Expand Down