fix(gatsby): webpack warnings are no longer in object format by default #30801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
KyleAMathews
commented
Apr 10, 2021
| @@ -128,7 +128,8 @@ module.exports = async function build(program: IBuildArgs): Promise<void> { | |||
| stats = await buildProductionBundle(program, buildActivityTimer.span) | |||
|
|
|||
| if (stats.hasWarnings()) { | |||
| reportWebpackWarnings(stats.compilation.warnings, report) | |||
| const rawMessages = stats.toJson({ moduleTrace: false }) | |||
There was a problem hiding this comment.
this restores the object format from webpack 4
|
Hmmm Typescript problems sigh |
kamit-transient
added a commit
to kamit-transient/temp_gatsby_fix
that referenced
this pull request
Apr 10, 2021
vladar
added
topic: webpack/babel
vladar
approved these changes
Apr 12, 2021
This was referenced Apr 13, 2021
This was referenced Nov 28, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30780
Related: facebook/create-react-app#9943
You can use a canary version of Gatsby with this fix by installing
gatsby@webpack-split-fix