feat: upgrade gatsby-plugin-sharp to latest #3090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should remove the `vips warning` output.
|
Deploy preview ready! Built with commit 2c219cc |
|
Deploy preview ready! Built with commit 2c219cc |
|
I haven't wanted to upgrade because of this issue lovell/sharp#832 Seems like too big of regression — I'd rather wait until libvips 8.6 & Sharp 0.19 are out. Thoughts? |
|
Ah. That makes sense. I haven't been using that feature, so didn't notice a regression. Do they have an ETA for 8.6/0.19? It's not a big deal, but those console logs are pretty noisy. I'll close this in the meantime. (Though I'll probably keep using it locally. 😆) |
fk
added
API/Plugins
status: blocked
|
@jlengstorf Looks like sharp v0.19 is here: #3675! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove the
vips warningoutput.I've been using this with
yarn linkand it's been working properly without the console warnings. All tests pass with a couple snapshot updates. I think this should be good to go.