Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cloudflare Workers Sites deployment documentation #31173

Conversation

ben-xD
Copy link
Contributor

@ben-xD ben-xD commented May 1, 2021

Description

  • Remove references to Workers KV (key value store). This was never used/ beneficial for Gatsby deployments because it doesn't use KV. It's also free now, not $5. I suspect it was added because of this, but we are not using an existing worker to serve these files and we're not using the KV api's (import { getAssetFromKV } from "@cloudflare/kv-asset-handler").
  • Add step about npm run build because wrangler publish uploads local files, so it needs to be there.
  • Added alternatives: Gatsby Hosting and Cloudflare Pages

Note: I was not able to build the doc site, so I cannot confirm that the markdown links ([Gatsby Cloud Hosting](/docs/how-to/previews-deploys/hosting/deploying-to-gatsby-cloud.md)) are going to work.

Related Issues

Addresses the issue raised in #31103

…ed 📝

- Add extra step about building locally
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 1, 2021
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KyleAMathews KyleAMathews added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 1, 2021
@gatsbybot gatsbybot merged commit 5634ef9 into gatsbyjs:master May 1, 2021
@LekoArts LekoArts mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants