-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-telemetry): Read installedGatsbyVersion correctly for workspaces #31196
fix(gatsby-telemetry): Read installedGatsbyVersion correctly for workspaces #31196
Conversation
338ba86
to
f514204
Compare
I released this as We would need to backport this to v2 to get the widest distribution of this hotfix. |
Seems that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Published in |
For yarn workspaces (when
process.cwd()
) is not the parent directory wherenode_modules
includesgatsby
, the current code is unable to read the installed gatsby version. This attempts to fix that.Remember that
main
for thegatsby
package iscache-dir/commonjs/gatsby-browser-entry.js
so we need to strip out three segments to be able to resolve to rootCo drafted with the wonderful @jamo