Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contentful): pass reporter to retry function #31608

Merged
merged 2 commits into from
May 28, 2021

Conversation

axe312ger
Copy link
Collaborator

This will fix an issue discovered by @njbmartin at #29268 (review)

With the reporter passed, the retry will now work on assets as well.

@axe312ger axe312ger added status: needs core review Currently awaiting review from Core team member topic: source-contentful Related to Gatsby's integration with Contentful labels May 27, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 27, 2021
@axe312ger axe312ger removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 27, 2021
@njbmartin
Copy link
Contributor

Fixes #31590

@axe312ger
Copy link
Collaborator Author

@njbmartin ahh thanks for the link, didn't see the actual issue.

@wardpeet wardpeet removed the status: needs core review Currently awaiting review from Core team member label May 27, 2021
@axe312ger axe312ger added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed bot: merge on green Gatsbot will merge these PRs automatically when all tests passes labels May 27, 2021
@wardpeet wardpeet merged commit 26dbe09 into master May 28, 2021
@wardpeet wardpeet deleted the fix/contentful-image-retry branch May 28, 2021 14:12
moonmeister added a commit to moonmeister/gatsby that referenced this pull request Jun 1, 2021
* master: (23 commits)
  fix(gatsby-source-wordpress): Prevent "EADDRINUSE: address already in use 127.0.0.1" error (gatsbyjs#31713)
  feat(gatsby-source-wordpress: architecture.md (gatsbyjs#31537)
  chore(deps): update dependency @babel/node to ^7.14.2 (gatsbyjs#31690)
  chore(deps): update babel monorepo (gatsbyjs#31143)
  fix(gatsby): merge resolveType when merging abstract types (gatsbyjs#31710)
  chore(release): Publish next
  fix(gatsby): Correct config for svgo plugins whitelist
  chore: Add translations and validations to Contentful test (gatsbyjs#31533)
  chore(docs): Correct nginx spelling (gatsbyjs#31651)
  chore(docs): Update Jest instructions for v27 (gatsbyjs#31649)
  Fix typo in adding-search.md (gatsbyjs#31639)
  Fix typos in improving-build-performance.md (gatsbyjs#31640)
  feat(gatsby-source-wordpress): Fix false positive error if the URL and the responsePath are the same (gatsbyjs#31612)
  Fixed syntax error in example (gatsbyjs#31636)
  fix(contentful): pass reporter to retry function (gatsbyjs#31608)
  chore: Properly typecheck `gatsby` (gatsbyjs#31519)
  fix(gatsby-source-contentful): fix progress bar (gatsbyjs#31467)
  fix(gatsby-plugin-gatsby-cloud): fix cloud being bundled (gatsbyjs#31604)
  chore(gatsby-source-wordpress): Fix typos (gatsbyjs#31600)
  chore(docs): Add title to release notes (gatsbyjs#31595)
  ...
LekoArts pushed a commit that referenced this pull request Jun 2, 2021
LekoArts pushed a commit that referenced this pull request Jun 2, 2021
(cherry picked from commit 26dbe09)

Co-authored-by: Benedikt Rötsch <axe312ger@users.noreply.github.com>
@LekoArts
Copy link
Contributor

LekoArts commented Jun 2, 2021

Published in gatsby-source-contentful@5.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants