-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-source-shopify): removed apikey references/usage from shopify plugin #32024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Jun 22, 2021
DanielSLew
added
the
topic: source-shopify
Related to the gatsby-source-shopify plugin
label
Jun 22, 2021
sslotsky
approved these changes
Jun 22, 2021
DanielSLew
changed the title
removed apikey references/usage from shopify plugin
feat(gatsby-source-shopify): removed apikey references/usage from shopify plugin
Jun 22, 2021
DanielSLew
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Jun 22, 2021
vladar
pushed a commit
that referenced
this pull request
Jun 22, 2021
(cherry picked from commit 47cf675)
gatsbybot
pushed a commit
that referenced
this pull request
Jun 22, 2021
This was referenced Jun 23, 2021
This was referenced Jan 18, 2022
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation
The usage of
apiKey
is no longer required, we can get rid of references of it and remove it from being required in the plugin options. This gives us more flexibility as we no longer need to obtain an api key when setting up a user's site.Related Issues