Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Deprecate schema-related APIs in sourceNodes #32291

Merged
merged 8 commits into from
Sep 10, 2021

Conversation

abhiaiyer91
Copy link
Contributor

@abhiaiyer91 abhiaiyer91 commented Jul 7, 2021

Description

Deprecates APIs in sourceNodes that should happen in createSchemaCustomization

Documentation

Related Issues

[ch22646]
[ch31764]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 7, 2021
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've realized that we need this change for other schema-related actions as well:

createFieldExtension and addThirdPartySchema should also be updated. And likely there are some test snapshots that must be updated as well.

@vladar vladar removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 8, 2021
@LekoArts LekoArts added the topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) label Jul 8, 2021
@LekoArts LekoArts changed the title Deprecate createTypes in sourceNodes fix(gatsby): Deprecate schema-related APIs in sourceNodes Jul 8, 2021
@abhiaiyer91
Copy link
Contributor Author

@vladar updated a test and regenerated snapshots. What do I do about Peril?

@abhiaiyer91
Copy link
Contributor Author

Also looks like the snapshot incorrectly updated a worker test. @LekoArts something i did wrong?

@gatsbyjs gatsbyjs deleted a comment from gatsbot bot Jul 13, 2021
@LekoArts
Copy link
Contributor

LekoArts commented Jul 13, 2021

Peril is sometimes acting weird, we can ignore that. The snapshot change in the worker I'm not sure about myself, I just reverted it and let's see if it passes. It shouldn't have changed anything there so maybe you missed an env var or something

@LekoArts
Copy link
Contributor

This is btw how it will look like then:

image

@LekoArts LekoArts added the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Jul 13, 2021
@wardpeet wardpeet removed the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Sep 10, 2021
@vladar vladar merged commit 3401149 into master Sep 10, 2021
@vladar vladar deleted the disallowCreateTypes branch September 10, 2021 13:48
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
…32291)

* Deprecate createTypes in sourceNodes

* Update the restriction list for other schema-related actions

* Update snapshots

* Restore package.test.js.snap

* Restore share-state.ts

Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Ward Peeters <ward@coding-tech.com>
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants