-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): Deprecate schema-related APIs in sourceNodes #32291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've realized that we need this change for other schema-related actions as well:
createFieldExtension
and addThirdPartySchema
should also be updated. And likely there are some test snapshots that must be updated as well.
@vladar updated a test and regenerated snapshots. What do I do about Peril? |
Also looks like the snapshot incorrectly updated a worker test. @LekoArts something i did wrong? |
Peril is sometimes acting weird, we can ignore that. The snapshot change in the worker I'm not sure about myself, I just reverted it and let's see if it passes. It shouldn't have changed anything there so maybe you missed an env var or something |
…32291) * Deprecate createTypes in sourceNodes * Update the restriction list for other schema-related actions * Update snapshots * Restore package.test.js.snap * Restore share-state.ts Co-authored-by: Lennart <lekoarts@gmail.com> Co-authored-by: Ward Peeters <ward@coding-tech.com> Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Description
Deprecates APIs in
sourceNodes
that should happen increateSchemaCustomization
Documentation
Related Issues
[ch22646]
[ch31764]