-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby): add environment variable for setting tracing config file #32513
chore(gatsby): add environment variable for setting tracing config file #32513
Conversation
I was just following up on his PR review. if someone could let us know when it may be actioned that be cool! - Than you |
Gatsby confirmed today @rudouglas
|
Is this PR still on track to be merged in by Aug 31st? |
This is great! Pushed a couple of updates to standardize the env var name & document it. I've been thinking/working on tracing support a fair bit this week. Just posted a discussion topic @ #33145 & have put up some PRs:
Would love y'all's thoughts on improving Gatsby's observability support. |
@KyleAMathews amazing thanks for looking at this, and thanks for the fresh PR's they look awesome and will really help get more valuable data from tracing. We would love to collaborate more and making this even more valuable 🥇 |
@KyleAMathews Thank you! |
…le (gatsbyjs#32513) * chore: add option for openTracingConfigFile env * chore: format * Standardize env variable name + document Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
Description
Currently, the only way to enable tracing is to pass the
--open-tracing-config-file
flag as part of thegatsby build/develop
commands.Because Gatsby Cloud just seems to run
gatsby build
and ignores these flags in thepackage.json
, it's not possible to enable tracing on Gatsby CloudThis enables tracing by allowing a user to set
GATSBY_OPEN_TRACING_CONFIG_FILE
instead