Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): add environment variable for setting tracing config file #32513

Merged
merged 5 commits into from
Sep 11, 2021

Conversation

rudouglas
Copy link
Contributor

@rudouglas rudouglas commented Jul 26, 2021

Description

Currently, the only way to enable tracing is to pass the --open-tracing-config-file flag as part of the gatsby build/develop commands.

Because Gatsby Cloud just seems to run gatsby build and ignores these flags in the package.json, it's not possible to enable tracing on Gatsby Cloud

This enables tracing by allowing a user to set GATSBY_OPEN_TRACING_CONFIG_FILE instead

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 26, 2021
@jpvajda
Copy link

jpvajda commented Aug 5, 2021

I was just following up on his PR review. if someone could let us know when it may be actioned that be cool! - Than you

@jpvajda
Copy link

jpvajda commented Aug 18, 2021

Gatsby confirmed today @rudouglas

The tracing PR that you made is being addressed in the current sprint this week!

@jpvajda
Copy link

jpvajda commented Aug 30, 2021

Is this PR still on track to be merged in by Aug 31st?

@KyleAMathews KyleAMathews added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 10, 2021
@KyleAMathews KyleAMathews changed the title chore: add option for openTracingConfigFile env chore(gatsby): add option for openTracingConfigFile env Sep 10, 2021
@KyleAMathews KyleAMathews changed the title chore(gatsby): add option for openTracingConfigFile env chore(gatsby): add option for GATSBY_OPEN_TRACING_CONFIG_FILE env Sep 10, 2021
@KyleAMathews KyleAMathews changed the title chore(gatsby): add option for GATSBY_OPEN_TRACING_CONFIG_FILE env chore(gatsby): add environment variable for setting tracing config file Sep 10, 2021
@KyleAMathews
Copy link
Contributor

This is great!

Pushed a couple of updates to standardize the env var name & document it.

I've been thinking/working on tracing support a fair bit this week. Just posted a discussion topic @ #33145 & have put up some PRs:

Would love y'all's thoughts on improving Gatsby's observability support.

@KyleAMathews KyleAMathews merged commit 323920d into gatsbyjs:master Sep 11, 2021
@rudouglas
Copy link
Contributor Author

@KyleAMathews amazing thanks for looking at this, and thanks for the fresh PR's they look awesome and will really help get more valuable data from tracing. We would love to collaborate more and making this even more valuable 🥇

@jpvajda
Copy link

jpvajda commented Sep 13, 2021

@KyleAMathews Thank you!

pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
…le (gatsbyjs#32513)

* chore: add option for openTracingConfigFile env

* chore: format

* Standardize env variable name + document

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants