Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust inline highlighting #3282

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Conversation

Ethan-Arrowood
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood commented Dec 20, 2017

The changed code highlighting is slightly off. This should fix it and should highlight the correct chunks of new code for the Glamor example.

screen shot 2017-12-20 at 12 08 01 am

The highlighting should extend to the closing `div` tag

screen shot 2017-12-20 at 12 08 10 am

The highlighting should not include `< p > Glamor is cool < /p >` as that was added in a previous example.

The changed code highlighting is slightly off. This should fix it and should highlight the correct chunks of new code for the Glamor example.
@KyleAMathews
Copy link
Contributor

Nice, thanks! Those are tricky 😅

@KyleAMathews KyleAMathews merged commit bd13bdc into gatsbyjs:master Dec 20, 2017
@Ethan-Arrowood
Copy link
Contributor Author

Great tutorials by the way! I'm loving the introduction 😄

@Ethan-Arrowood Ethan-Arrowood deleted the patch-1 branch December 20, 2017 05:12
@KyleAMathews
Copy link
Contributor

Thanks!

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 5868f40

https://deploy-preview-3282--gatsbygram.netlify.com

@jlengstorf
Copy link
Contributor

Hiya @Ethan-Arrowood! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

This was referenced Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants