Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-core-utils): Move page-data & HTML utils to package #32861

Merged
merged 16 commits into from
Aug 23, 2021
Merged

feat(gatsby-core-utils): Move page-data & HTML utils to package #32861

merged 16 commits into from
Aug 23, 2021

Conversation

abhiaiyer91
Copy link
Contributor

@abhiaiyer91 abhiaiyer91 commented Aug 20, 2021 •
edited
Loading

Extract some common functions across packages into core-utils

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 20, 2021
@abhiaiyer91 abhiaiyer91 requested a review from LekoArts August 20, 2021 15:55
@abhiaiyer91 abhiaiyer91 changed the title Add html file path util to core-utils Extract some page utils to core-utils Aug 20, 2021
@abhiaiyer91 abhiaiyer91 requested a review from wardpeet August 20, 2021 16:03
@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 23, 2021
@LekoArts LekoArts changed the title Extract some page utils to core-utils feat(gatsby-core-utils): Move page-data & HTML utils to package Aug 23, 2021
@gatsbyjs gatsbyjs deleted a comment from gatsbot bot Aug 23, 2021
LekoArts
LekoArts approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@abhiaiyer91 abhiaiyer91 merged commit 114e3d3 into master Aug 23, 2021
@abhiaiyer91 abhiaiyer91 deleted the moreUtils branch August 23, 2021 13:07
@merceyz merceyz mentioned this pull request Oct 19, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

@wardpeet wardpeet Awaiting requested review from wardpeet

Assignees
No one assigned
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhiaiyer91 @LekoArts