fix(gatsby-plugin-gatsby-cloud): add backpressure for IPC #32963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds backpressure to IPC to prevent message loss in case of process exiting early. As mentioned in docs on
process.send
:Also related: nodejs/node#7657 (comment)
This PR also adds batching for
emitRoute
IPC calls.P.S. GitHub diff here is pretty messy, use
Files Changed -> Settings -> Hide whitespace characters
to make it readable.Caveat: Jest
Apparently, Jest sets up an incorrect stub for
process.send
which returnsundefined
: https://github.com/facebook/jest/blob/98f10e698ae986c19fef2d8117be2341bcfb8f7f/packages/jest-util/src/createProcessObject.ts#L113Node always returns
boolean
fromprocess.send
(1, 2). To account for this - had to trick Jest by changing the original implementation to this.Edit: submitted a PR to Jest with a proposed fix: jestjs/jest#11799