-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-plugin-page-creator): Fix gatsby plugin page creator v4 #33120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Sep 9, 2021
DanielSLew
changed the title
Fix gatsby plugin page creator v4
fix(gatsby-plugin-page-creator): Fix gatsby plugin page creator v4
Sep 9, 2021
DanielSLew
added
gatsby 4
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Sep 9, 2021
DanielSLew
changed the title
fix(gatsby-plugin-page-creator): Fix gatsby plugin page creator v4
feat(gatsby-plugin-page-creator): Fix gatsby plugin page creator v4
Sep 9, 2021
wardpeet
reviewed
Sep 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small remark. I need to test it to make sure but looks good!
Co-authored-by: Ward Peeters <ward@coding-tech.com>
wardpeet
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jun 19, 2022
This was referenced Jun 19, 2022
This was referenced Jun 19, 2022
This was referenced Jan 31, 2023
This was referenced Jan 31, 2023
This was referenced Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to unblock the gatsby-starter-shopify from being migrated to Gatsby v4 we needed to fix the
gatsbyPath
resolver. This resolver relies on extensions from the program, but this program wasn't getting fully set in the workers.We also needed to use
onPluginInit
when compatible with the Gatsby version.Documentation
Related Issues