Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): let serve use getServerData headers #33159

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Sep 13, 2021

Description

This exposes custom headers set by getServerData to engine integration and actually allows setting those reponse headers in gatsby serve

[ch37799]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 13, 2021
@pieh pieh added topic: render-mode Related to Gatsby's different rendering modes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 13, 2021
@pieh pieh marked this pull request as ready for review September 13, 2021 15:17
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments about types

packages/gatsby/src/utils/page-ssr-module/entry.ts Outdated Show resolved Hide resolved
packages/gatsby/src/utils/get-server-data.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wardpeet wardpeet merged commit fe2f09b into master Sep 13, 2021
@wardpeet wardpeet deleted the ssr-expose-headers branch September 13, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: render-mode Related to Gatsby's different rendering modes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants