Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): assign correct parentSpans to PQR activities #33568

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Oct 18, 2021

Description

This is fixing couple of activities (notably PQR related) that weren't setting parentSpan correctly and traces were not correct because of it

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 18, 2021
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 18, 2021
parentSpan: buildActivityTimer.span,
parentSpan: buildSpan,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildActivityTimer (activity for browser bundling) would finish before it, so that parentSpan was incorrect

Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pieh pieh merged commit 8dbf550 into master Oct 18, 2021
@pieh pieh deleted the fix/pqr-tracing-spans branch October 18, 2021 10:01
wardpeet pushed a commit to herecydev/gatsby that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants