fix(gatsby): single page node manifest accuracy #33642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
removed
the
status: triage needed
|
@KyleAMathews this is why your demo was showing the warnings when you were trying to use |
|
Haha it was too simple!
…On Fri, Oct 22, 2021, 4:45 PM Tyler Barnes ***@***.***> wrote:
@KyleAMathews <https://github.com/KyleAMathews> this is why your demo was
showing the warnings when you were trying to use ownerNodeId and the
filesystem route API. I think your test site only had a single related page
for each node manifest 😅
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33642 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAARLB3OYM6FITDB7LELQQTUIHZR7ANCNFSM5GRSLKKA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
DanielSLew
approved these changes
Oct 25, 2021
vladar
pushed a commit
that referenced
this pull request
Oct 27, 2021
* expect the manifest has the correct foundPageBy * ensure foundPageBy is accurate when there's only 1 relevant page (cherry picked from commit 4b6d04b)
vladar
added a commit
that referenced
this pull request
Oct 27, 2021
* expect the manifest has the correct foundPageBy * ensure foundPageBy is accurate when there's only 1 relevant page (cherry picked from commit 4b6d04b) Co-authored-by: Tyler Barnes <tyler@gatsbyjs.com> Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
wardpeet
pushed a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
* expect the manifest has the correct foundPageBy * ensure foundPageBy is accurate when there's only 1 relevant page
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
* expect the manifest has the correct foundPageBy * ensure foundPageBy is accurate when there's only 1 relevant page
This was referenced Jun 6, 2022
This was referenced Jun 7, 2022
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes 2 improvements to the
createNodeManifestaction:foundPageByproperty (the way the page was found for the manifest)foundPageByasqueryTrackingeven if was actually found viaownerNodeIdor the filesystem route API