Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-drupal): Ensure all new nodes are created before creating relationships #33864

Merged
merged 3 commits into from
Nov 9, 2021

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Nov 4, 2021

Fix issue reported by @jstramel where when he created a new page w/ a new media entity, the media entity wouldn't be attached to the page node in Gatsby as it wasn't yet created.

We solve this by creating all new nodes before we update node relationships.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 4, 2021
@KyleAMathews KyleAMathews added topic: source-drupal Related to Gatsby's integration with Drupal and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 4, 2021
@jstramel
Copy link
Contributor

jstramel commented Nov 9, 2021

This fix solved the issue of newly added media not being attached during the build.

@KyleAMathews KyleAMathews merged commit 9cf4c05 into master Nov 9, 2021
@KyleAMathews KyleAMathews deleted the create-entities-first branch November 9, 2021 22:35
LekoArts pushed a commit that referenced this pull request Nov 10, 2021
…eating relationships (#33864)

* fix(gatsby-source-drupal): Ensure all new nodes are created before creating relationships

* fixes

* Add support for webhook bodies as well

(cherry picked from commit 9cf4c05)
LekoArts pushed a commit that referenced this pull request Nov 10, 2021
…eating relationships (#33864) (#33926)

Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
@LekoArts
Copy link
Contributor

Successfully published in gatsby-source-drupal@5.1.2

vladar pushed a commit that referenced this pull request Nov 18, 2021
…eating relationships (#33864)

* fix(gatsby-source-drupal): Ensure all new nodes are created before creating relationships

* fixes

* Add support for webhook bodies as well

(cherry picked from commit 9cf4c05)
vladar pushed a commit that referenced this pull request Nov 18, 2021
…eating relationships (#33864) (#34019)

* fix(gatsby-source-drupal): Ensure all new nodes are created before creating relationships

* fixes

* Add support for webhook bodies as well

(cherry picked from commit 9cf4c05)

Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-drupal Related to Gatsby's integration with Drupal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants