-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): Update mini-css-extract-plugin to fix inc builds issue #33979
Conversation
The tests for global styles are failing now because the
So in the e2e test the generated HTML is pointing to a different location than what is generated. Right now both at We'd need to further look into https://webpack.js.org/guides/asset-modules/ |
Description
Update
mini-css-extract-plugin
to fix a weird cache/recompilation issue.css-loader
also needed to be updated due to webpack-contrib/css-loader#1384 bug (hash was different in client-side/SSR)Failing test assertion was added in #33982 and this PR should fix this.
Related Issues
Fixes #33450
[ch40612]