fix(gatsby): ensure that writing node manifests to disk does not break on Windows (#33853) #34020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k on Windows (#33853) * fix: ensure that writing node manifests to disk does not break on Windows * refactor: use joinPath helper when creating node manifest file name * feat: replace all invalid Windows file path chars when creating node manifest files * test: use joinPath helper in node manifest tests * feat: only replace special windows chars in the manifest filename * feat: do not use negative look behind for Windows hard drive name * test: add tests for windows node manifest file name character replacing (cherry picked from commit f525ce0)
gatsbot
bot
added
the
status: triage needed
vladar
removed
the
status: triage needed
vladar
approved these changes
Nov 18, 2021
This was referenced Jun 6, 2022
This was referenced Jun 7, 2022
This was referenced Jun 7, 2022
This was referenced Jun 7, 2022
This was referenced Jun 7, 2022
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #33853 to the 3.14 release branch
(cherry picked from commit f525ce0)