Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): ensure that writing node manifests to disk does not break on Windows (#33853) #34020

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

gatsbybot
Copy link
Collaborator

Backporting #33853 to the 3.14 release branch

(cherry picked from commit f525ce0)

…k on Windows (#33853)

* fix: ensure that writing node manifests to disk does not break on Windows

* refactor: use joinPath helper when creating node manifest file name

* feat: replace all invalid Windows file path chars when creating node manifest files

* test: use joinPath helper in node manifest tests

* feat: only replace special windows chars in the manifest filename

* feat: do not use negative look behind for Windows hard drive name

* test: add tests for windows node manifest file name character replacing

(cherry picked from commit f525ce0)
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 18, 2021
@vladar vladar removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 18, 2021
@vladar vladar merged commit 1589bd8 into release/3.14 Nov 18, 2021
@vladar vladar deleted the backport-3.14-33853 branch November 18, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants