fix(gatsby): handle loaded page being potentially undefined #34488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
added
the
topic: frontend
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
LekoArts
approved these changes
Jan 14, 2022
marvinjude
pushed a commit
that referenced
this pull request
Jan 17, 2022
(cherry picked from commit 59cd704)
tyhopp
pushed a commit
that referenced
this pull request
Jan 17, 2022
|
Published in |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I introduced regression in #34225 for cases when
loader.loadPagereturnsundefined. This adds just check wether nested properties are defined.Proper error handling is below, but we still want to potentially check for
webpackCompilationHashbefore that (to potentially reload instead of just throwing error)Related Issues
Fixes #34484