Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-schema-snapshot): unlink file on init #34527

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

njbmartin
Copy link
Contributor

Description

Fixes a compatibility issue with parallel queries. With multiple sources, createSchemaCustomization is called a number of times. Setting the update option will try to remove the file, resulting in a race condition, so this has been moved to onPluginInit so it is only removed once.

Documentation

N/A

Related Issues

N/A

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 18, 2022
@pieh pieh added topic: GraphQL Related to Gatsby's GraphQL layer and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 19, 2022
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pieh pieh merged commit 42ed5ef into gatsbyjs:master Jan 19, 2022
@njbmartin njbmartin deleted the fix/plugin-schema-snapshot-unlink branch January 20, 2022 13:38
LekoArts pushed a commit that referenced this pull request Jan 24, 2022
LekoArts pushed a commit that referenced this pull request Jan 24, 2022
Co-authored-by: Nicholas Martin <nicholas.martin@builtbyrebels.com>
@LekoArts
Copy link
Contributor

Published in gatsby-plugin-schema-snapshot@3.5.1

pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: GraphQL Related to Gatsby's GraphQL layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants