-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): Content Sync DSG bug #34799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DSG has the same issue as query-on-demand where queries are not ran so it's going to be difficult to make this work unless people give you ownerId or use fs routes
We're on the same page about that @wardpeet :) I think the perf improvement to be made here is to iterate over all pages only 1 time before we start processing node manifests and make a Map or two to quickly look up the needed info. In this change we're now iterating on all pages for each node manifest which isn't great. |
(cherry picked from commit bfd04d3)
Published in |
I recently discovered Content Sync no longer works with DSG. I could've sworn it used to but it doesn't now. This fix will be less performant for large sites. I'm going to follow this PR up with another that will improve performance but since we have a marketing release of Content Sync next week I don't want to make too many code changes before then. This is the most minimal change required to make Content Sync work w/ DSG.