fix: compatibility with react rc 2 #35108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
topic: core
imjoshin
previously approved these changes
Mar 11, 2022
There was a problem hiding this comment.
This looks good to me, but I'd recommend getting another set of eyes for approval. 😄
One thought for potential future refactor: is there any way we could pull out the renderer/hydrator logic into a common factory-type class? This subject is a bit in-the-weeds-y and I could see more duplicated logic with new plugins in the future.
LekoArts
suggested changes
Mar 15, 2022
packages/gatsby-plugin-image/src/components/gatsby-image.browser.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| root.render(Component) | ||
|
|
||
| return root |
There was a problem hiding this comment.
Maybe I'm missing some context here, but why is with React 18 the reactRender returning something, with older version it's void?
There was a problem hiding this comment.
Because Root doesn't exist in React < 18 and we need the root so we only call createRoot once.
…er.tsx Co-authored-by: Lennart <lekoarts@gmail.com>
LekoArts
previously approved these changes
Mar 15, 2022
wardpeet
added
bot: merge on green
LekoArts
approved these changes
Mar 15, 2022
|
This merge seems to have introduced a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes support for React 18 latest RC.
Related Issues
Fixes #35095
Fixes #35083
Fixes #35094
[sc-47335]