fix(gatsby-cli): Resolve babel preset ts explicitly #35153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: cli
LekoArts
approved these changes
Mar 17, 2022
gatsbybot
pushed a commit
that referenced
this pull request
Mar 18, 2022
(cherry picked from commit 30ecc7d)
pieh
added a commit
that referenced
this pull request
Mar 18, 2022
|
Published in |
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced May 13, 2024
This was referenced May 14, 2024
This was referenced May 14, 2024
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to babel/babel-loader#166 (comment), Babel can't access the TS preset unless resolved explicitly.
Reason for this is in
create-gatsbywerequirehandlers fromgatsby-cli(presumably to avoid adding Babel deps tocreate-gatsbysince they may not be needed if customers don't select plugins in the questionnaire [?]) and as a result of the above issue Babel isn't aware of the preset available ingatsby-cli.Validated locally by pointing
create-gatsbyto my fork ofgatsby-starter-minimal-tswith the patch applied - https://github.com/tyhopp/gatsby-starter-minimal-ts.This will need to be released as a patch before #35128 can be merged
Documentation
No new docs needed
Related Issues
[sc-47001]