-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): fix eperm when cache getting cleared #35154
Conversation
@@ -270,6 +269,7 @@ export async function initialize({ | |||
? lmdbCacheDirExists | |||
: cacheJsonDirExists | |||
|
|||
const { globby: glob } = await import(`globby`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for this not to be a static import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ESM only, i'll add a comment
https://unpkg.com/globby@13.1.1/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing 🤔
I guess it's yarnl lock updates. I'll update it in different PR to figure it out |
ecbe007
to
2d42a8e
Compare
(cherry picked from commit 6684c60)
Published in |
Description
Fixes EPERM when cache needs to be cleared. We used
del
anddel
uses gracefulFs but it's not good enough on windows as it doens't retry enough.fs-extra
does a better job.Related Issues
Fixes #35086