Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Bump react-dev-utils to v12 #35468

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Conversation

GaryPWhite
Copy link

@GaryPWhite GaryPWhite commented Apr 21, 2022

downstream, react-dev-utils v11.x.x is subject to a vulnerability through its direct dependency on immer <9.0.6. Since the release of 12.x.x, immer has been bumped up and should resolve the "critical" security alert if it's adopted into Gatsby.

Description

Bumped version of react-dev-utils. Not a lot of functionality changed (look between "publish" commits) this is a dependency upkeep change.

Documentation

comparing release pages for dev-utils doesn't show much change in the API that I've seen. Open to being wrong or missing something.

Related Issues

GHSA-33f9-j839-rf8h, I don't see any issues about this from a search on the issues board.

downstream, [react-dev-utils v11.x.x](https://www.npmjs.com/package/react-dev-utils/v/11.0.4) is subject to a [vulnerability](GHSA-33f9-j839-rf8h). Since the release of 12.x.x, `immer` [has been bumped up](facebook/create-react-app#11364 (comment)) and should resolve the "critical" security alert if it's adopted into Gatsby.
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 21, 2022
@GaryPWhite
Copy link
Author

GaryPWhite commented Apr 21, 2022

oh wow, missed this before, but it does seem like this might be a much bigger change than I anticipated.

Turns out that react-dev-utils dropped support for before version 14. I can tell that 10 is past EOL and 12 is getting there, but unsure how the team will adopt new versions atm. Depending on interest in updating, this PR might be sitting for a while or become useless :/ would be happy to get a second opinion.

@wardpeet
Copy link
Contributor

wardpeet commented Apr 21, 2022

node 14.15 is the lowest version we support right now so we should be good

@mbicknese
Copy link

node 14.15 is the lowest version we support right now so we should be good

Unrelated to this issue, which lgtm, should the node 14+ be reflected in the top-level package.json? The current engine field states "node": ">=12.13.0"

@LekoArts
Copy link
Contributor

The relevant engines key is here, so it's okay:

"node": ">=14.15.0"

@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 25, 2022
@LekoArts LekoArts changed the title Bump react-dev-utils chore(gatsby): Bump react-dev-utils to v12 Apr 25, 2022
@GaryPWhite
Copy link
Author

thanks for the clarity, all!

Let me know if there's anything I should dig into here. The failures appear to be... obscure... like failing since something is already running :) I'm happy to dive in but assume maybe something else is happening on the tests at the moment. Happy to help where requested!

Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts merged commit 63828fc into gatsbyjs:master Apr 28, 2022
@GaryPWhite GaryPWhite deleted the patch-1 branch April 29, 2022 13:55
@ruchernchong
Copy link

Is this released soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants