Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-script): Make load callback work when both load and error callbacks defined #35760

Merged
merged 1 commit into from
May 27, 2022
Merged

fix(gatsby-script): Make load callback work when both load and error callbacks defined #35760

merged 1 commit into from
May 27, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented May 26, 2022

Description

Fix case where onLoad does not fire when both onLoad and onError callbacks are passed to the script component. Edge case that fell through the cracks since the e2e tests tested onLoad and onError cases separately.

Documentation

N/A

Related Issues

[sc-51154]

@tyhopp tyhopp added the topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) label May 26, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 26, 2022
@tyhopp tyhopp added type: cherry and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 26, 2022
@tyhopp tyhopp merged commit b491560 into master May 27, 2022
@tyhopp tyhopp deleted the fix-script-component-both-callback-usage branch May 27, 2022 02:30
pieh pushed a commit that referenced this pull request May 30, 2022
@tyhopp @pieh
fix(gatsby-script): Make load callback work when both load and error …
ae29a51 
…callbacks defined (#35760)

(cherry picked from commit b491560)
@gatsbybot gatsbybot mentioned this pull request May 30, 2022
Merged
pieh pushed a commit that referenced this pull request May 31, 2022
@gatsbybot @tyhopp
fix(gatsby-script): Make load callback work when both load and error …
ae95d66 
…callbacks defined (#35760) (#35787)

Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
@pieh
Copy link
Contributor

pieh commented Jun 1, 2022

Published in gatsby@4.15.2 / gatsby-script@1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyhopp @pieh