feat(gatsby-source-shopify): Add query runtime warning for CI environments #36142
Conversation
gatsbot
bot
added
the
status: triage needed
imjoshin
added
topic: source-shopify
| @@ -68,6 +72,19 @@ export function createOperations( | |||
| while (!finishedStatuses.includes(currentBulkOperation.status)) { | |||
| await new Promise(resolve => setTimeout(resolve, 1000)) | |||
| currentBulkOperation = (await currentOperation()).currentBulkOperation | |||
|
|
|||
| // add warning for CI environments | |||
There was a problem hiding this comment.
@j0sh77 aren't there activities in Gatsby Cloud as well? What's different about CI vs local?
There was a problem hiding this comment.
To be honest, I'm not sure what qualifies to be shown in Gatsby Cloud or not. I'm not seeing anything around these long-running queries in Cloud currently. The site I'm testing with definitely has a long running query that I can reproduce locally.
@LekoArts would you happen to know if there's other qualifies an activity to show up?
There was a problem hiding this comment.
Maybe the activityTimer call needs an id or parentSpan to show up in the UI? 🤔 For example this activity timer shows up there https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/src/commands/build.ts#L358-L363
There was a problem hiding this comment.
Yeah, that could be. I think this warning is still a valuable add outside of the activity timer.
There was a problem hiding this comment.
Do you have a screenshot of what this looks like on Gatsby Cloud? Just want to make sure it doesn't look super messy in the structured logs view.
There was a problem hiding this comment.
I also added a slowdown. After the first few alerts, it starts increasing the time in which it warns.
There was a problem hiding this comment.
Ah I mean in the structured logs view. But since it's slowing down over time now it should be good :) I was just worried about getting a super long page in the structured view
Description
In non-CI environments, we have an activity to track when queries are long-running. In CI environments (
CI=1), we have no knowledge of long-running queries. This should help us have more insight into a shopify site's long build times.Example:
[sc-51358]