fix(gatsby): use pathPrefix for SSR/DSG page-data requests with gatsby serve
#36231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
pieh
force-pushed
the
fix/engines/path-prefix-serve
branch
from
e134160
to
01a61c9
Compare
pieh
commented
Jul 25, 2022
| handler(request, response, { | ||
| public: path.resolve(`assets`), | ||
| headers: [ | ||
| { | ||
| source: `**/*`, | ||
| headers: [ | ||
| { | ||
| key: `Access-Control-Allow-Origin`, | ||
| value: `*`, | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }) | ||
| proxy.web(request, response, { target: "http://localhost:9000" }) |
There was a problem hiding this comment.
used proxy here instead of separate serve because of "on-demand" behaviour of DSG/SSR which would need to be either replicated here (or just forward request to serve to let it handle it)
pieh
commented
Jul 25, 2022
| app.get( | ||
| router.get( |
There was a problem hiding this comment.
actual fix - router strips path prefix and enables engines to find proper pages
tyhopp
approved these changes
Jul 26, 2022
This was referenced Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start with failing test and SSR page to
path-prefixe2e tests and couple of assertions, will be followed by a fix to make it greenRelated Issues
Fixes #35406