-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use GCS for pipeline tests #36413
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
added
the
topic: automation
Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot
label
Aug 18, 2022
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Aug 18, 2022
LekoArts
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Aug 18, 2022
julienp
previously approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
marvinjude
previously approved these changes
Aug 18, 2022
pieh
previously approved these changes
Aug 18, 2022
LekoArts
dismissed stale reviews from pieh, marvinjude, and julienp
via
August 18, 2022 13:47
fd831a4
pieh
approved these changes
Aug 18, 2022
LekoArts
added
the
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
label
Aug 18, 2022
This was referenced Nov 26, 2023
This was referenced Nov 26, 2023
This was referenced Nov 26, 2023
This was referenced May 15, 2024
This was referenced May 15, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
topic: automation
Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unsplash seems to be changing the files and thus failing our tests. So we moved the files to our GCS. I've downloaded the images from those URLs and each ran
npx md5-file photoA.jpeg
to generate the new hashes for the tests