fix: drop __renderedByLocation prop when calculating slice props hashes and don't expose it to slice component
#36979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shes and don't expose it to slice component
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: core
LekoArts
approved these changes
Nov 7, 2022
This was referenced Nov 8, 2022
This was referenced Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is implementation detail we use for better code frames that currently is:
a) exposed to slice template itself (should not be there)
b) can change the props hash when
<Slice>placeholder change position in js file and therefore force rebuilds we don't want or needDocumentation
Related Issues