-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-source-wordpress): WPGraphQL 1.13.0 compatibility #37134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of hardcoding the ofType path which can be at any depth
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Nov 30, 2022
TylerBarnes
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Nov 30, 2022
…on the built type
LekoArts
added
topic: source-wordpress
Related to Gatsby's integration with WordPress
topic: source-plugins
Relates to the Gatsby source plugins (e.g. -filesystem)
labels
Dec 1, 2022
This was referenced May 26, 2023
This was referenced May 26, 2023
This was referenced May 26, 2023
This was referenced May 27, 2023
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: source-plugins
Relates to the Gatsby source plugins (e.g. -filesystem)
topic: source-wordpress
Related to Gatsby's integration with WordPress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37114
WPGraphQL v1.13.0 included a breaking change in a minor version because for most consumers they wouldn't notice. For
gatsby-source-wordpress
it was very much a huge breaking change as it broke many of the assumptions this plugin made about the WPGraphQL schema.I had to change a lot of code to make the plugin keep working with older versions of WPGraphQL and the new version, I'll add some comments to the files view instead of writing it all here
In this PR I kept the integration tests WPGraphQL version to an older version to make sure these changes are backwards compatible. In #37146 I upgrade the itests version to the 1.13.4
This change is also released as a canary
gatsby-source-wordpress@7.3.0-alpha-wpgql-thirteen.20