Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Improve SlicePlaceholderProps type #37409

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Jan 5, 2023

Description

I've found https://stackoverflow.com/questions/75017011/gatsby-5-ts-and-new-slice-component and it's a valid bug:

image

The root cause is the lack of this feature request that would allow our intended usage: microsoft/TypeScript#17867

So we're sacrificing some type guards here but all the proposed solutions in the issue and on SO didn't work.

Documentation

No update needed

Related Issues

[ch59899]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 5, 2023
@LekoArts LekoArts added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 5, 2023
@LekoArts LekoArts merged commit c7b5e7c into master Jan 5, 2023
@LekoArts LekoArts deleted the slice-ts-type branch January 5, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants