Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): nodeModel.findAll supports v5 sort argument structure #37477

Merged
merged 2 commits into from
Jan 17, 2023
Merged

fix(gatsby): nodeModel.findAll supports v5 sort argument structure #37477

merged 2 commits into from
Jan 17, 2023

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Jan 16, 2023 •
edited
Loading

Description

context.nodeModel.findAll currently doesn't work with new sort syntax/structure - it still expects olds syntax with fields and order fields which was largely based as-is in #36708 as we only changed "front" in graphql schema and immediately converted to old structures for internal processing, but just in our resolver. nodeModel still expects old structure today, which shold be considered a bug.

Documentation

Related Issues

[sc-60184]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 16, 2023
@pieh pieh added topic: GraphQL Related to Gatsby's GraphQL layer and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 16, 2023
@pieh pieh marked this pull request as ready for review January 16, 2023 22:26
@pieh pieh merged commit 949132b into master Jan 17, 2023
@pieh pieh deleted the fix/node-model-find-all-new-syntax branch January 17, 2023 07:47
@gatsbybot gatsbybot mentioned this pull request Jan 17, 2023
Merged
LekoArts pushed a commit that referenced this pull request Jan 17, 2023
@pieh @LekoArts
fix(gatsby): nodeModel.findAll supports v5 sort argument structure (#…
a141bfd 
…37477)

* add failing test

* fix(gatsby): nodeModel.findAll supports v5 sort argument structure

(cherry picked from commit 949132b)
LekoArts pushed a commit that referenced this pull request Jan 17, 2023
@gatsbybot @pieh
fix(gatsby): nodeModel.findAll supports v5 sort argument structure (#…
00ed53a 
…37477) (#37479)

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
@LekoArts
Copy link
Contributor

Published in gatsby@5.4.2

@MaxMood96 MaxMood96 mentioned this pull request Jan 24, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 24, 2023
Open
@0xSebin 0xSebin mentioned this pull request Jan 24, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Jan 24, 2023
Open
This was referenced Jan 24, 2023
Open
Open
@0xSebin 0xSebin mentioned this pull request Jan 24, 2023
Open
This was referenced Jan 24, 2023
Open
Open
Open
@nidhi42 nidhi42 mentioned this pull request Jan 25, 2023
Open
This was referenced Jan 25, 2023
Open
Open
This was referenced Jan 25, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Feb 6, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Mar 24, 2023
Open
laurenskling added a commit to laurenskling/gatsby that referenced this pull request Sep 1, 2023
@laurenskling
Update node-model.js to new sort syntax
146e805 
As per gatsbyjs#37477, the nodeModel can use the new sort syntax
@laurenskling laurenskling mentioned this pull request Sep 1, 2023
Merged
pieh pushed a commit that referenced this pull request Sep 7, 2023
@laurenskling
docs: Update node-model.js to new sort syntax (#38515)
f55d88d 
As per #37477, the nodeModel can use the new sort syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: GraphQL Related to Gatsby's GraphQL layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieh @LekoArts