-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-react-router-scroll): fix issues with anchor links #37498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t if a hash is present in the URL otherwise scroll to the previously recorded position.
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Jan 19, 2023
LekoArts
added
topic: frontend
Relates to frontend issues (e.g. reach/router, gatsby-link, page-loading, asset-loading, navigation)
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Jan 19, 2023
LekoArts
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This was referenced Jan 24, 2023
This was referenced Jan 25, 2023
Hi! I am on Gatsby 5.6.0 but I am still experiencing these issues with anchor points being completely random.. let me know if I should open a separate issue.. |
Still on Gatsby 5.12.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: frontend
Relates to frontend issues (e.g. reach/router, gatsby-link, page-loading, asset-loading, navigation)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the following issue:
When a user visits an anchor link (i.e. from an external website or by entering it in their browser) and then scrolls, if the user revisits the same link (again, from an external website or by entering it in their browser) they are taken to where they last scrolled to instead of the actual anchor point.
Note that this PR makes fixes that were missed from issue #28555.
Please note the following comment that was made some time ago in the
scroll-handler.js
:Notably, the author writes about the URL being treated as the source of truth. The change in this PR enforces that behaviour.
Documentation
The feature is used simply by navigation via hyperlinks with anchors across different pages.
Related Issues
Fixes #28555.