Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Fix typo in Head API reference #37630

Merged
merged 1 commit into from
Feb 9, 2023
Merged

chore(docs): Fix typo in Head API reference #37630

merged 1 commit into from
Feb 9, 2023

Conversation

gh640
Copy link
Contributor

@gh640 gh640 commented Feb 9, 2023

Description

The following sample code leads to a SyntaxError with unterminated JSX contents.

export function Head() {
  return (
    <>
      <html lang="en">
      <body className="my-body-class">
      <title>Hello World</title>
    </>
  )
}

<html> and <body> should ends with />:

export function Head() {
  return (
    <>
      <html lang="en" />
      <body className="my-body-class" />
      <title>Hello World</title>
    </>
  )
}

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 9, 2023
@LekoArts LekoArts added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 9, 2023
@LekoArts LekoArts changed the title Fix unterminated JSX in sample code in Gatsby Head API page chore(docs): Fix typo in Head API reference Feb 9, 2023
@LekoArts LekoArts merged commit d70f1f1 into gatsbyjs:master Feb 9, 2023
@gh640 gh640 deleted the patch-2 branch February 9, 2023 07:39
@gh640
Copy link
Contributor Author

gh640 commented Feb 9, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gh640 @LekoArts