Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-gatsby): Add Tailwind as a styling choice #37944

Merged
merged 11 commits into from
May 10, 2023

Conversation

ChrisLaRocque
Copy link
Contributor

@ChrisLaRocque ChrisLaRocque commented Apr 14, 2023

Description

This change adds Tailwind as an option to the list of styling choices when running npm init gatsby

For this new functionality was added to the shape of the questionare:

  • isGatsbyPlugin can be used to not add the key of the object to the plugins list
  • files to write files inside the stubs folder to the user's project

Documentation

N/A

Tests

Build the CLI locally and then run it somewhere else with Node

Related Issues

N/A

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 14, 2023
@LekoArts LekoArts changed the title Adds Tailwind as a styling choice when running init gatsby feat(create-gatsby): Add Tailwind as a styling choice Apr 17, 2023
@LekoArts LekoArts added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 17, 2023
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is too much of a one-off and needs to be more generic. All the definitions must reside in questions/styles.json as that's the source of truth

packages/create-gatsby/src/index.ts Outdated Show resolved Hide resolved
packages/create-gatsby/src/init-starter.ts Outdated Show resolved Hide resolved
packages/create-gatsby/src/init-starter.ts Outdated Show resolved Hide resolved
@LekoArts LekoArts dismissed their stale review May 9, 2023 14:17

My changes were addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cli Related to the Gatsby CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants