Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: image and file cdn url generator adapter implementation #38685

Merged
merged 33 commits into from
Dec 15, 2023
Merged

feat: image and file cdn url generator adapter implementation #38685

merged 33 commits into from
Dec 15, 2023

Commits on Nov 2, 2023

  1. alternate image url construction

    @kathmbeck
    kathmbeck committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    3ff1518 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into alternate-image-url

    @kathmbeck
    kathmbeck authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    8c4b42a View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. try using image cdn in e2e site

    @pieh
    pieh committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    aee50e6 View commit details
    Browse the repository at this point in the history

  2. Update netlify.toml

    @kathmbeck
    kathmbeck authored Nov 3, 2023
    Configuration menu
    Copy the full SHA
    6b3bdbe View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. have separate check for dispatching image and file service

    @pieh
    pieh committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    3f8efd2 View commit details
    Browse the repository at this point in the history

  2. fix tests?

    @pieh
    pieh committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    40d2add View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. try to use images from deploy (so we can avoid using ones hosted exte… 

    …rnally)
    @pieh
    pieh committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    9ebede5 View commit details
    Browse the repository at this point in the history

  2. replicate prod-runtime imagecdn tests in adapters

    @pieh
    pieh committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    599f34d View commit details
    Browse the repository at this point in the history

  3. fix import

    @pieh
    pieh committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    011228a View commit details
    Browse the repository at this point in the history

  4. adjusting remote-file tests

    @pieh
    pieh committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    d9dea3f View commit details
    Browse the repository at this point in the history

  5. adjusting remote-file tests 2

    @pieh
    pieh committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    f89b551 View commit details
    Browse the repository at this point in the history

  6. cleanup/test

    @kathmbeck
    kathmbeck committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    57fdd3a View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. assert naturalWidth/height in image-cdn tests (both adapters and prod… 

    …uction-runtime)
    @pieh
    pieh committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    1a8df77 View commit details
    Browse the repository at this point in the history

  2. remove unused

    @pieh
    pieh committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    36b918a View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. don't use path prefix for alternate image cdn url

    @pieh
    pieh committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    5b81ecd View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into alternate-image-url

    @pieh
    pieh committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    d324338 View commit details
    Browse the repository at this point in the history

  3. _gatsby/file is prefixed

    @pieh
    pieh committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    0975496 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. feat: move custom image cdn url generator implementation to adapter (#… 

    …38715)

* feat: move custom image cdn url generator implementation to adapter

* provide public types for custom image cdn url generator function signature and individual arguments
    @pieh
    pieh authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    d31412a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into alternate-image-url

    @kathmbeck
    kathmbeck authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    ed5f3bf View commit details
    Browse the repository at this point in the history

  3. use position/cover

    @kathmbeck
    kathmbeck committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    370d2b4 View commit details
    Browse the repository at this point in the history

  4. update comment

    @kathmbeck
    kathmbeck committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    3527298 View commit details
    Browse the repository at this point in the history

  5. update docs

    @kathmbeck
    kathmbeck committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    a175d3b View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Merge remote-tracking branch 'origin/master' into alternate-image-url

    @pieh
    pieh committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    4ba752e View commit details
    Browse the repository at this point in the history

  2. chore: types/jsdocs shuffle

    @pieh
    pieh committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    4514117 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. apply suggestion from https://github.com/gatsbyjs/gatsby/pull/38685\#… 

    …discussion_r1414135797
    @pieh
    pieh committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    c7b3da3 View commit details
    Browse the repository at this point in the history

  2. remove docs from feature branch

    @pieh
    pieh committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    78b108c View commit details
    Browse the repository at this point in the history

  3. feat: provide custom FILE_CDN url generator from adapter (#38735) 

    * feat: provide file cdn from adapters

* update test

* fix tests

* use edge function for non-image File CDN

* why edge function was not deployed?

* bump netlify-cli

* ?

* bump node for adapters tests

* add execa to dev deps

* cleanup

* some jsdocs updates
    @pieh
    pieh authored Dec 6, 2023
    Configuration menu
    Copy the full SHA
    d82f88f View commit details
    Browse the repository at this point in the history

  4. add note that generated urls ideally are relative, but can be absolut… 

    …e as well
    @pieh
    pieh committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    53ce56d View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. feat: allow adding remote file allowed url patterns (#38719) 

    * feat: move custom image cdn url generator implementation to adapter

* provide public types for custom image cdn url generator function signature and individual arguments

* feat: allow adding image cdn allowed url patterns

* Module.createRequireFromPath doesn't exist anymore in Node 18, and because package requires at least that version we remove it

* fix contentful source image url

* fix wordpress source image url

* rename ImageCdnAllowed to RemoteFileAllowed as it's not just for image cdn

* compare allowed remote urls in netlify.toml with ones generated by gatsby

* url testing in filecdn

* jsdocs

* print warnings for netlify.toml about missing remote_images patterns

* test if any existing pattern in netlify.toml allow needed remote url instead of just string comparison
    @pieh
    pieh authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    7de5336 View commit details
    Browse the repository at this point in the history

  2. chore: update adapter README about imageCDN

    @pieh
    pieh committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    8f1bc5d View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Merge remote-tracking branch 'origin/master' into alternate-image-url

    @pieh
    pieh committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    434a946 View commit details
    Browse the repository at this point in the history

  2. use correct remote_images for adapters e2e site

    @pieh
    pieh committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    1bb2e01 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into alternate-image-url

    @pieh
    pieh committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    1c79840 View commit details
    Browse the repository at this point in the history