perf(gatsby-adapter-netlify): improve adapt() performance #38988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
pieh
force-pushed
the
perf/netlify-adapter-headers-redirects
branch
from
126f69c
to
b217a0e
Compare
pieh
force-pushed
the
perf/netlify-adapter-headers-redirects
branch
from
b217a0e
to
c7c750b
Compare
pieh
force-pushed
the
perf/netlify-adapter-headers-redirects
branch
from
9b17cb7
to
d02cb5c
Compare
…d causing fetch warning on node 18 impacting some logs assertions
…in route manifest
pieh
changed the title
mrstork
approved these changes
May 28, 2024
pieh
added a commit
that referenced
this pull request
May 29, 2024
* test: add ssg specific headers * fix: headers rule matching with path prefix * test: add NODE_NO_WARNING, axios seems to use fetch now under the hood causing fetch warning on node 18 impacting some logs assertions * perf: don't recreate headers from headerRoutes for each static route in route manifest * test: apply NODE_NO_WARNINGS env in correct place (cherry picked from commit ec77bed)
pieh
added a commit
that referenced
this pull request
May 29, 2024
* test: add ssg specific headers * fix: headers rule matching with path prefix * test: add NODE_NO_WARNING, axios seems to use fetch now under the hood causing fetch warning on node 18 impacting some logs assertions * perf: don't recreate headers from headerRoutes for each static route in route manifest * test: apply NODE_NO_WARNINGS env in correct place (cherry picked from commit ec77bed)
pieh
added a commit
that referenced
this pull request
May 29, 2024
…38991) * perf(gatsby-adapter-netlify): improve adapt() performance (#38988) * test: add ssg specific headers * fix: headers rule matching with path prefix * test: add NODE_NO_WARNING, axios seems to use fetch now under the hood causing fetch warning on node 18 impacting some logs assertions * perf: don't recreate headers from headerRoutes for each static route in route manifest * test: apply NODE_NO_WARNINGS env in correct place (cherry picked from commit ec77bed) * chore: update caniuse-lite db --------- Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapter was regenerating
_headerscontent for each static route in routes manifest which was resulting in really poor performance with large sites, this fixes it to generate_headerscontent only once.Some measurements of impact on
adapt()perf (I temporarily added timer for that - it is not part of this PR) on test sitebefore:
after:
The changes can be tested using canary releases:
Tests
Adapter tests and in particular header tests continue to pass. Added some adjustments to fixture (and some test updates), but they are not changing what was asserted before - just adding to them with additional case of
headersrules for subset of pages which happen to be SSGRelated Issues
FRA-303