Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add createContentDigest helper for transformer-yaml plugin #8813

Merged
merged 1 commit into from
Oct 8, 2018
Merged

add createContentDigest helper for transformer-yaml plugin #8813

merged 1 commit into from
Oct 8, 2018

Conversation

nathan78906
Copy link
Contributor

added the createContentDigest helper for the gatsby-transformer-yaml plugin

from
#8805

@KyleAMathews
Copy link
Contributor

Is there any reason to mock the response of createContentDigest?

@nathan78906
Copy link
Contributor Author

Seems like it was done in the original PR
d87ecd1
b856b56
2440dbb

@pieh
Copy link
Contributor

pieh commented Oct 8, 2018

Is there any reason to mock the response of createContentDigest?

He would need to import it from gatsby as transformer plugins run onCreateNode themselves in tests. This is how we also use to test createNodeId stuff. I think this is fine to mock it, as we are not testing createContentDigest here

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nathan78906!

@pieh pieh merged commit 5dca291 into gatsbyjs:master Oct 8, 2018
lipis added a commit to lipis/gatsby that referenced this pull request Oct 9, 2018
* 'master' of github.com:gatsbyjs/gatsby: (66 commits)
  Fixed typos and made styling changes (gatsbyjs#8938)
  fixed typo in migrating-from-v0-to-v1.md (gatsbyjs#8921)
  Add https://developer.bitcoin.com/ to the Site Showcase (gatsbyjs#8931)
  Remove code block (gatsbyjs#8930)
  test(gatsby-plugin-feed): don't snapshot test platform specific (gatsbyjs#8836)
  test: add gatsby-node tests for plugin manifest (gatsbyjs#8598)
  fix(docs): Fix typo in using-gatsby-image.md (gatsbyjs#8889)
  docs: Correcting code diff highlights (gatsbyjs#8913)
  docs: e-commerce tutorial - allow cors request from react fetch (gatsbyjs#8660)
  docs: Updated code diff highlighting (gatsbyjs#8914)
  fix(www): Correct wrong entries in sites + starters (gatsbyjs#8888)
  fix(docs): consistent links to other tutorial parts (gatsbyjs#8860)
  feat(docs): Create "Using Fragments" article (gatsbyjs#8902)
  Use title syntax on markdown code blocks (gatsbyjs#8912)
  chore: use createContentDigest helper (gatsbyjs#8813)
  Updated hyperlink (gatsbyjs#8856)
  [v2/starter] Gatsby v2 Starter based on Bulma (gatsbyjs#8884)
  docs: update Web App Manifest compat (gatsbyjs#8891)
  docs: fix gatsby-source-graphql README links (gatsbyjs#8886)
  docs: fix diff highlighting in StaticQuery example (gatsbyjs#8892)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants