mapping #4
mapping #4
Conversation
fbrv
force-pushed
the
fb/pubkey-url-mapping
branch
from
4e4dbe1
to
b775579
Compare
fbrv
force-pushed
the
fb/pubkey-url-mapping
branch
3 times, most recently
from
8b8a692
to
367a554
Compare
fbrv
force-pushed
the
fb/pubkey-url-mapping
branch
from
2b19daa
to
d8f37ba
Compare
fbrv
force-pushed
the
fb/pubkey-url-mapping
branch
from
9983716
to
2b564c3
Compare
src/config.rs
Outdated
| #[serde(rename = "beacon-urls")] | ||
| pub beacon_urls: Vec<String>, | ||
| #[serde(rename = "lookahead")] | ||
| pub lookahead_providers_relays: Vec<Lookahead>, |
There was a problem hiding this comment.
should this be something like lookaheads ?
src/config.rs
Outdated
| #[serde(rename = "chain-id")] | ||
| pub chain_id: u16, | ||
| #[serde(rename = "relay-urls")] | ||
| pub relay_urls: Vec<String>, | ||
| #[serde(rename = "relays")] |
src/lookahead/manager.rs
Outdated
| None => bail!("no lookahead provider found"), | ||
| Some(entry) => match &self.url_provider { | ||
| UrlProvider::LookaheadEntry => { | ||
| Ok(Url::from_str(&entry.url).expect("not a valid url")) |
There was a problem hiding this comment.
i dont think we should panic here, eg. if there is a malformed string coming from the provider. Let's return an error and log the wrong string
src/forward_service.rs
Outdated
| .route("/", post(forward_request)) | ||
| .layer(TraceLayer::new_for_http()) | ||
| .with_state(Arc::new(shared_state)) | ||
| } | ||
|
|
||
| #[tracing::instrument] |
There was a problem hiding this comment.
this would log the full function parameters every time , which is a bit verbose. We can customize what is added to the span https://docs.rs/tracing/latest/tracing/attr.instrument.html
There was a problem hiding this comment.
we should log all errors but otherwise we can keep debug/trace for others , otherwise logging for each request may be create too much overhead
| #[serde(rename = "registry")] | ||
| pub registry: Option<HashMap<BlsPublicKey, Url>>, | ||
| #[serde(rename = "url-provider")] | ||
| pub url_provider: UrlProvider, | ||
| } | ||
|
|
||
| impl Config { |
There was a problem hiding this comment.
should we add some validation here? eg if there' s no relays
No description provided.