-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerequisite is a set, ensure all dependencies are known/valid when reported #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
Hmm one thing that has just occurred to me is that with this change, it is possible for bad WPH->SR mappings to be accepted, because we are simply trusting the mappings from guaranteed reports. If you collaborate with another guarantor you can get bogus mappings in the recent blocks state without punishment by sharing bogus guarantees but refusing to send any shards out. |
To elaborate a bit, I'm thinking something along the following lines could happen:
|
Yup - so to fix this we need to ensure that the WP of incoming WRs not only don't appear in the Recent Blocks list but also not the Accumulated or Ready Queue. |
Fixes #103