Several pvm fixes #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omega_W uses the serviceindex `s` which is not set as argument
the info function merges bold d with `x_n` which is not passed as argument
the upgrade function was missing the `_n` subscription as `x[s]` is not a valid "reference"
t is being used when defining a but not provided like in forget
delta is being used in the "return" matching cases
p_c does no longer exist. it's been renamed to u
|
Thanks for all these! For what it's worth, the final item is an incorrect change - it is defined as a derivative field: 
|
gavofyork
added a commit
that referenced
this pull request
Oct 7, 2024
|
Since these are somewhat conflicting with #57, I'll be manually merging them in to 0.4. |
gavofyork
added a commit
that referenced
this pull request
Oct 8, 2024
* Fix discrepency between Phi and Phi_1 * Bandersnatch: Ignore bad keys * Use padding point for bad keys in ring * Bandersnatch def * Initial drafting * Further development * Continued efforts * Proper queue * Simplify accumulation gas system * More.. * More bits * Almost completed * Clarify hash function * Start on the appendix * More work * Some work on off-chain * Further work on PVM invocation * More work. * Panic should return gas counter * For upgrade, transfer and quit, just use the context directly and don't pass s/d * Clean up a bit of text * Correct spelling * More spelling * WP2WR: More succinct formalism * More work on lookup dict * Cleanup leftovers * Fix host function new * Make halt from host-function possible * Final bits * Cleanups * Formatting * Spelling * Final on-chain elements. * Formatting * Tighten up PVM init formalism * Formatting for Merklisation * Serialization for boxplus * Formatting of accumulation * Fixes from #86 by @vekexasia * Remove file. * Bump to 0.4.0 * Fix accumulated-hat * Rewordings relating to accumulation * Update readme and try to keep constant octet lengths under W * Fix function * Update dependencies * Tighten up language in accumulation * Fixes from review * Fix the Delta+ description * Remove unneeded min * Merklise new state * Remove old term * Keep chunks around until the finality of the block in which they become available. * PVM: Fix register initialization * PVM: Fix register indices in hostcalls * WP&WR: Include auth output for Psi_R function * WP&WR: tighten constraints for srlookup value * WP&WR: Fix up the av.spec definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes different typos.
In order by commit:
s- commitx[s]does not have a valid reference. it should have beenx_{n}[s]- committin the first return case should be bold - committparameter used when buildingbold_a- commiti->l- commitcno longer exist so replacedcwithu- commit