Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show measurement results on plot #47

Closed
gavv opened this issue Oct 9, 2023 · 1 comment
Closed

Show measurement results on plot #47

gavv opened this issue Oct 9, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Contributions are welcome user interface GUI

Comments

@gavv
Copy link
Owner

gavv commented Oct 9, 2023

Currently GUI shows real-time plot of emitted and captured signal and labels with latest measurement results (hardware + software latency, hardware latency, and average hardware latency):

image

It would be nice to add an option when the plot shows measurement results instead of the signal (e.g. graphs of the three latencies). We could add a combobox which defines what to show on plot, signal or results.

Note that there are two types of measurement results: one in "latency_corr"/"latency_step" modes, and another in "losses" mode.
@gavv gavv added help wanted Contributions are welcome good first issue Good for newcomers user interface GUI labels Oct 9, 2023
@gavv gavv mentioned this issue Oct 9, 2023
Merged
RandomJanis added a commit to RandomJanis/signal-estimator that referenced this issue Oct 23, 2023
@RandomJanis
Results now can be ploted
09a4a1d 
Issue gavv#47
Now results are ploted.
Added gui checkboxes to hide curves if desired.
Since Signals and results values are on diferent scale, they use
seperate Y axis. Still it is not perfect, because for losses there are 3
diferent Y dimensions and only 2 Y axis are aviable.
@RandomJanis RandomJanis mentioned this issue Oct 23, 2023
Merged
@gavv
Copy link
Owner Author

gavv commented Oct 30, 2023

Landed!

@gavv gavv closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Contributions are welcome user interface GUI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gavv