Support for protobuf >= 22 by using find_package(Protobuf CONFIG) #3331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Fix compatibility with protobuf >= 22, similar to gazebosim/gz-msgs#346 and other PRs linked there.
Summary
To minimize the risk of regression when protobuf < 22 is used, the protobuf version is obtained via pkg-config. If protobuf >= 22 is detected, then
find_package(Protobuf CONFIG REQUIRED)
is used andprotobuf::libprotobuf
andprotobuf::libprotobuf
are linked to make sure that the dependency with abseil is correctly handled.Test it
See conda-forge CI that now passes. Probably this PR can also be tested on homebrew that recently upgraded protobuf to 23.2, see Homebrew/homebrew-core#132957 .
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.